v36 audit: C2/C4 intentional-divergence + node-local doc annotations - #91
Merged
Conversation
C2: merged-chain weights are intentionally flat (no decay) vs the parent LTC decayed-cumulative skiplist, mirroring p2pool get_v36_merged_weights. C4: get_merged_expected_payouts and build_pplns_coinbase_hex output ordering is node-local and non-consensus — the DOGE aux coinbase is submitted only to dogecoind (accepts any valid ordering); the sharechain commits to merged work via the AuxPoW merkle proof, never by re-deriving coinbase outputs across peers. Documentation only; no behavioral change. Closes the C1-C7 cross-check loop (C1/C3/C5 already-satisfied, C6/C7 confirmed, C7 ltc CHAIN_LENGTH=8640).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc-only audit annotations from the C1–C7 v36 consensus cross-check. No code changes — 15 comment lines across 2 files, off master 3de14ba (commit 894593e, GPG-signed).
Annotations
src/impl/ltc/share_tracker.hpp:2307: marks the merged-chain FLAT (att-weighted, no time-decay) weighting as an INTENTIONAL divergence from the parent/LTC decayed-cumulative path. Mirrors p2poolget_v36_merged_weights(flat + cap, data.py:2657). Verified intentional, not a bug.get_merged_expected_payouts(share_tracker.hpp) +build_pplns_coinbase_hex(merged_mining.cpp): annotates both as NODE-LOCAL / NON-CONSENSUS. Output ordering feeds only the locally-assembled DOGE aux-coinbase submitted to dogecoind; peers validate the merged commitment via the AuxPoW merkle proof, not by re-deriving outputs.Scope / safety